Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pidigits resurected #10555

Merged
merged 1 commit into from
Nov 18, 2013
Merged

pidigits resurected #10555

merged 1 commit into from
Nov 18, 2013

Conversation

TeXitoi
Copy link
Contributor

@TeXitoi TeXitoi commented Nov 18, 2013

Changes:

  • default value when no args
  • license
  • removed libc printing
  • use extra::bigint instead of handmade gmp binding

The drawback is that it's 2 order of magnitude slower, the good news is that there is a good bench for extra::bigint.

Changes:
* default value when no args
* license
* removed libc printing
* use extra::bigint instead of handmade gmp binding
bors added a commit that referenced this pull request Nov 18, 2013
Changes:
* default value when no args
* license
* removed libc printing
* use extra::bigint instead of handmade gmp binding

The drawback is that it's 2 order of magnitude slower, the good news is that there is a good bench for extra::bigint.
@bors bors closed this Nov 18, 2013
@bors bors merged commit ec27c09 into rust-lang:master Nov 18, 2013
@TeXitoi TeXitoi deleted the pidigits-resurected branch December 1, 2013 18:15
flip1995 pushed a commit to flip1995/rust that referenced this pull request Jun 30, 2023
Ignore more type aliases in unnecessary_cast

Fixes rust-lang#10555

changelog: [`unnecessary_cast`]: No longer lints cast from locals that are type aliases
flip1995 pushed a commit to flip1995/rust that referenced this pull request Jun 30, 2023
Ignore more type aliases in `unnecessary_cast`

This is potentially the worst code I've ever written, and even if not, it's very close to being on par with starb. This will ignore `call() as i32` and `local_obtained_from_call as i32` now.

This should fix every reasonable way to reproduce rust-lang#10555, but likely not entirely.

changelog: Ignore more type aliases in `unnecessary_cast`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants